That looks good for a start, but, please, add doug.gregor to reviewers and
ping him to look at your design.
A couple of minor comments follow.
* It would be a bit more convenient if you added more context to your patch.
If you use svn, you can use "svn diff --diff-cmd diff -x -uU99999" to achieve
this, otherwise, you can probably figure out how to do this in git.
================
Comment at: lib/AST/ASTDumper.h:1
@@ +1,2 @@
+//===--- ASTDumper.h - Dumping implementation for ASTS ----------*- C++
-*-===//
+//
----------------
"ASTs"?
================
Comment at: lib/AST/StmtDumper.cpp:33
@@ -49,1 +32,3 @@
+ StmtDumper(ASTDumper &Dumper, raw_ostream &OS)
+ : Dumper(Dumper), OS(OS) {
}
----------------
Any reasons for a separate raw_ostream (there's one in the ASTDumper already)?
http://llvm-reviews.chandlerc.com/D52
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
