On Tue, Oct 2, 2012 at 5:15 PM, Dmitri Gribenko <[email protected]> wrote:
> On Tue, Oct 2, 2012 at 5:59 PM, Alexander Kornienko <[email protected]> > wrote: > > So I'm definitely for using FileCheck in this case, but it's only me, > others > > may disagree. > > I'm in favor of ASTMatchers-based tests for anything dumping related, > based on my experience of maintaining > test/Index/annotate-comments.cpp. Any small change to the testcases > forces a change of line numbers for everything that follows it (half > of tests, on average). FileCheck has variables now, maybe we can add a special __LINE__ variable (possibly with a way to specify offset)? In this case we could put CHECK lines near the actual test code and this would not be bound to absolute line numbers. What do you think? > With ASTMatchers-based tests we can keep all > logically related tests in a single file and keep the test case close > to the expected output while ensuring that different tests are > isolated from each other. > Isolation is possible now using separate RUN lines with specific -D defines and #ifdef blocks. -- Regards, Alex
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
