On Tue, Oct 23, 2012 at 11:23 AM, jahanian <[email protected]> wrote: > > On Oct 19, 2012, at 11:18 PM, Nico Weber <[email protected]> wrote: > >> Author: nico >> Date: Sat Oct 20 01:18:14 2012 >> New Revision: 166370 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=166370&view=rev >> Log: >> Accept -Wno-arc-abi without warning for a while. >> >> Xcode 4.5 passes -Wno-arc-abi to clang, which makes a clang newer than >> r163917 warn that it doesn't understand -Wno-arc-abi. I asked if adding >> this is ok at >> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121015/066433.html >> and nobody objected. >> >> Adding this makes life a bit easier for the chromium project. If you think >> this is a burden on for clang, shout, and I'll revert this. > > This is OK. Please add a test case.
Thanks! Test added in r166540. > > - Fariborz > >> >> >> Modified: >> cfe/trunk/include/clang/Basic/DiagnosticGroups.td >> >> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=166370&r1=166369&r2=166370&view=diff >> ============================================================================== >> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original) >> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Sat Oct 20 01:18:14 >> 2012 >> @@ -279,6 +279,8 @@ >> def CustomAtomic : DiagGroup<"custom-atomic-properties">; >> def AtomicProperties : DiagGroup<"atomic-properties", >> [ImplicitAtomic, CustomAtomic]>; >> +// FIXME: Remove arc-abi once an Xcode is released that doesn't pass this >> flag. >> +def : DiagGroup<"arc-abi">; >> def ARCUnsafeRetainedAssign : DiagGroup<"arc-unsafe-retained-assign">; >> def ARCRetainCycles : DiagGroup<"arc-retain-cycles">; >> def ARCNonPodMemAccess : DiagGroup<"arc-non-pod-memaccess">; >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
