Not commenting on the DebugInfo caching part. But as a general comment, if there was a performance hit, you may want to provide performance numbers before and after this patch, say on Cocoa.h, and sample of other more modern framework files which use if private ivars (and of course while generating debug info).
- Fariborz On Feb 26, 2013, at 6:08 PM, Adrian Prantl <[email protected]> wrote: > Hi CFEers, > > After re-thinking it, here is an updated version of this patch that does not > completely disable caching for incomplete interfaces. This should minimize > the performance hit of the previous version. > Basically I am now storing ObjCInterface-Types in a separate cache, together > with a “checksum” (really the number of ivars). If we look up the type again, > I see if the checksum changed and otherwise just return the type from the > cache. > > -- Adrian > > <0001-Ensure-that-DIType-is-regenerated-after-we-visited-a.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
