================
Comment at: lib/Format/Format.cpp:49
@@ -48,2 +48,3 @@
static void mapping(llvm::yaml::IO &IO, clang::format::FormatStyle &Style) {
+
if (!IO.outputting()) {
----------------
Any reason to put an extra newline here?
================
Comment at: lib/Format/Format.cpp:58
@@ +57,3 @@
+ ArrayRef<StringRef> Styles(StylesArray);
+ for (size_t i = 0; i < Styles.size(); ++i) {
+ StringRef StyleName(Styles[i]);
----------------
Use llvm-style loop?
================
Comment at: tools/clang-format/ClangFormat.cpp:83
@@ +82,3 @@
+ bool IsFile = false;
+ llvm::sys::fs::is_regular_file(Twine(ConfigFile), IsFile);
+ if (IsFile) {
----------------
Any reason to ignore the error?
http://llvm-reviews.chandlerc.com/D758
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
