On Fri, May 10, 2013 at 1:57 PM, Alexander Kornienko <ale...@google.com> wrote:
>
> ================
> Comment at: lib/Format/Format.cpp:61
> @@ +60,3 @@
> + if (Style == clang::format::getPredefinedStyle(StyleName)) {
> + IO.mapOptional("# BasedOnStyle", StyleName);
> + break;
> ----------------
> Kim Gräsman wrote:
>> IIRC, the YAML parser doesn't take "#" comments, only JavaScript-style "//",
>> but I'm not 100% sure. Did you try roundtripping a dumped configuration?
>
> There's a round-trip test, and it passes for me.
Thanks, I had it backwards -- it only takes the Python-style "#".
Didn't see the round-trip test until just now, good to see it's
covered!
- Kim
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
