On Wed, Jun 12, 2013 at 10:59 AM, Richard Smith <[email protected]> wrote: > On Tue, Jun 11, 2013 at 10:37 PM, <[email protected]> wrote: >> >> Joerg Sonnenberger <[email protected]> writes: >> >> Do you mean something like this? >> > >> > Yes, with a few more (non-trivial) test vectors. >> >> Here's a version with some more interesting tests. I've also opted to >> treat __builtin_clz(0) as non-const as per Richard's suggestion. > > > Don't return false from VisitCallExpr without emitting a diagnostic (see the > comment at the top of the file) -- replace the > > if (!Val) > return false; > > with > > if (!Val) > return Error(E); > > Otherwise LGTM, thanks!
Committed with that tweak as r183886. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
