On Thu, Jun 20, 2013 at 4:00 PM, Alexander Kornienko <[email protected]>wrote:
> > Looks good. > > > ================ > Comment at: include/clang/ASTMatchers/ASTMatchers.h:2298 > @@ +2297,3 @@ > + TOOLING_COMPILE_ASSERT( > + (llvm::is_base_of<Stmt, NodeType>::value) || > + (llvm::is_base_of<Decl, NodeType>::value) || > ---------------- > Manuel Klimek wrote: > > Alexander Kornienko wrote: > > > Is wrapping this in parens a way to shut up some diagnostic? > > Yes. This is a macro, which otherwise takes the "," as the start of a > new parameter. > Then I'd leave parentheses only around the whole logical expression and > added a very short comment, so that nobody spends time trying to remove > them. > Used only one set of parens, but I don't think commenting on how C++ works is a good idea (otherwise, where do we stop). > > > http://llvm-reviews.chandlerc.com/D1009 > > BRANCH > equalsboundnode > > ARCANIST PROJECT > clang >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
