Looks good.
================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:2298 @@ +2297,3 @@ + TOOLING_COMPILE_ASSERT( + (llvm::is_base_of<Stmt, NodeType>::value) || + (llvm::is_base_of<Decl, NodeType>::value) || ---------------- Manuel Klimek wrote: > Alexander Kornienko wrote: > > Is wrapping this in parens a way to shut up some diagnostic? > Yes. This is a macro, which otherwise takes the "," as the start of a new > parameter. Then I'd leave parentheses only around the whole logical expression and added a very short comment, so that nobody spends time trying to remove them. http://llvm-reviews.chandlerc.com/D1009 BRANCH equalsboundnode ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
