================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:15
@@ -14,2 +14,3 @@
#include "clang/AST/ASTContext.h"
+#include "clang/AST/ASTLambda.h"
#include "clang/AST/DeclTemplate.h"
----------------
Hmm - I should probably get rid of this include for this patch at least.
================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:4196
@@ +4195,3 @@
+ if (isa<ParmVarDecl>(D) && !ParentDC->isDependentContext() &&
+ !cast<ParmVarDecl>(D)->getType()->isDependentType())
+ return D;
----------------
should this be isInstantiationDependentType() ?
================
Comment at: lib/Sema/TreeTransform.h:4580
@@ +4579,3 @@
+ //};
+ if (!T->isInstantiationDependentType() && !T->isVariablyModifiedType()) {
+ DecltypeTypeLoc NewTL = TLB.push<DecltypeTypeLoc>(TL.getType());
----------------
Oops - I need to get rid of !T->isVariablyModifiedType() - I believe Doug had
already asked for that. And isInstantiationDependentType() is the right
function to test here, correct?
================
Comment at: lib/Sema/TreeTransform.h:602
@@ +601,3 @@
+
+ return 0;
+ }
----------------
Should I just have this return the TPL that's passed in? or is null better?
http://llvm-reviews.chandlerc.com/D1784
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
