rsmith added inline comments. ================ Comment at: lib/Sema/SemaDeclCXX.cpp:4700-4703 @@ +4699,6 @@ + if (Member->getAttr<DLLExportAttr>()) { + if (TSK == TSK_ExplicitInstantiationDeclaration) + // Don't go any further if this is just an explicit instantiation + // declaration. + continue; + ---------------- Can we bail out of the function early in this case?
================ Comment at: lib/Sema/SemaDeclCXX.cpp:9501 @@ -9481,3 +9500,3 @@ void Sema::ActOnFinishCXXMemberDefaultArgs(Decl *D) { auto *RD = dyn_cast<CXXRecordDecl>(D); ---------------- Can you rename this to something more general, like `ActOnFinishCXXNonNestedClass`, now that we're using it to check things other than default arguments? http://reviews.llvm.org/D11850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits