bkramer added a subscriber: bkramer.
bkramer added a comment.

Is this tested? I'd expect a crash when constructing a StringRef implicitly 
from nullptr.


================
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:341
@@ -340,3 +340,3 @@
       SourceMgr.getFileID(Range.getEnd()))
-    return nullptr;
+    return StringRef(nullptr, 0);
 
----------------
You can just use the default ctor `return StringRef();`


http://reviews.llvm.org/D12186



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to