dcoughlin marked 2 inline comments as done. ================ Comment at: lib/StaticAnalyzer/Core/ExprEngineObjC.cpp:197 @@ +196,3 @@ + // Generate a transition to non-Nil state, dropping any potential + // non-nil flow. + if (notNilState != State) { ---------------- xazax.hun wrote: > Aren't we dropping the nil flow here instead of the non-nil? If that's the > case, the comment should reflect that. Yes, you're right. I'll update the comment.
================ Comment at: test/Analysis/objc-message.m:25 @@ +24,3 @@ + + // We intentionally drop the non-nil flow (dropping coverage) after a method + // call when the receiver may be nil in order to avoid inconsistencies of ---------------- This comment is wrong too (we drop the *nil* flow). I'll update it. http://reviews.llvm.org/D12123 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits