mclow.lists added a comment.

In http://reviews.llvm.org/D12355#233477, @bkramer wrote:

> Won't this do the wrong thing for embedded '\0' in a std::string?
>
>   std::string("hello\0world", 11).compare("hello")
>   
>
> should not return 0.


Good point; I think that pretty much kills this proposed change.


http://reviews.llvm.org/D12355



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to