compnerd added inline comments.
================
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
----------------
mkuper wrote:
> compnerd wrote:
> > Why does this need a builtin? Is an inline assembly block using lgdt
> > insufficient for some reason?
> I think using a builtin is, generally, cleaner.
> I'm ok with using inline asm (and abandoning the LLVM part of the patch), if
> that's the more popular option.
Yes, that is the preference in my experience. Please do switch to the inline
asm option.
http://reviews.llvm.org/D12278
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
