eugenis added a subscriber: eugenis.
eugenis added a comment.

This would greatly simplify the abi versioning change in 
http://reviews.llvm.org/D11740. Thanks for working on this!


================
Comment at: include/CMakeLists.txt:24
@@ +23,3 @@
+  -P ${LIBCXX_SOURCE_DIR}/cmake/Modules/CopyLibcxxHeaders.cmake
+  WORKING_DIRECTORY ${CMAKE_CURRENT_LIST_DIR})
+
----------------
This is creative :)
I don't know the usual cmake conventions, but CopyLibcxxHeaders is very 
different from other files in cmake/Modules in that it is a standalone script 
and not an included file. Should it be moved to smth like cmake/Scripts, or 
named differently?



http://reviews.llvm.org/D11963



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to