aadg added a comment.

Yet another comment (see below).


================
Comment at: lib/CodeGen/CGCall.cpp:2332
@@ -2331,2 +2331,3 @@
   if (!store) return nullptr;
+  if (store->getPointerOperand() != CGF.ReturnValue) return nullptr;
 
----------------
aadg wrote:
> It might be worth stating in a comment why this is needed --- for the benefit 
> of people who will read this code later.
I also note that those lines are looking very much like those in the if above 
(handling the multiple use of the return value case)... This issue was fixed 
above, but not here. Would it be possible to avoid code duplication ?


Repository:
  rL LLVM

http://reviews.llvm.org/D12400



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to