rnk added a comment.
There's a bunch of whitespace issues that clang-format can resolve. We also
have the convention that variables are StudlyCaps, which isn't followed in a
few places.
Do you need someone to commit this for you? If so, I can patch this in, test it
manually, and deal with the style stuff if you deal with the VSDir part.
================
Comment at: lib/Driver/MSVCToolChain.cpp:293
@@ +292,3 @@
+// specific header files. If not, they are probably shipped with Universal CRT.
+bool clang::driver::toolchains::MSVCToolChain::useUniversalCRT() const
+{
----------------
This should really take VSDir as a parameter instead of recomputing it, since
all the callers are already computing it.
http://reviews.llvm.org/D12695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
