andreybokhanko added a comment. Reid, thank you for the review!
One last confirmation (see below), and I'll go ahead. Yours, Andrey ================ Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN5test93barD2Ev + // CHECK4: call void @_ZN6test103barD2Ev bar ptr; ---------------- rnk wrote: > Isn't this still in the test9 namespace? Shouldn't this change be reverted? Now, after making the change you requested (wrapping checks in "default" part of adjustMemberFunctionCC function with !IsCtorOrDtor (SemaType.cpp:5876)) we start to call ~foo() here, so the check should be changed to: // CHECK4: call void bitcast (void (%"struct.test9::foo"*)* @_ZN5test93fooD2Ev Please confirm you are OK with this change and I'll go ahead with commit. http://reviews.llvm.org/D12402 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
