jpienaar added a comment.
Nice, so this will allow parsing/AST construction with builtins from 2
architectures but will fail to compile if a builtin for the host/device is
called from device/host.
You mention this is not generally possible. Can you give some examples?
================
Comment at: include/clang/Driver/CC1Options.td:329
@@ -328,1 +328,3 @@
+def aux_triple : Separate<["-"], "aux-triple">,
+ HelpText<"Auxiliary triple.">;
def code_completion_at : Separate<["-"], "code-completion-at">,
----------------
You use aux target in all the errors to the user so perhaps for consistency
"Triple for aux target". It could be more self-documenting too ("Triple for aux
target used during CUDA compilation."?) as I don't know if a lot of people
would be able to guess what the auxiliary triple is or where it is used.
================
Comment at: include/clang/Frontend/CompilerInstance.h:355
@@ -350,3 +354,3 @@
- /// Replace the current diagnostics engine.
+ /// Replace the current Target
void setTarget(TargetInfo *Value);
----------------
Nit: period at the end for uniformity.
http://reviews.llvm.org/D12917
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
