zaks.anna added inline comments.

================
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871
@@ +870,3 @@
+  if (RetRegion) {
+    State = setDynamicTypeInfo(State, RetRegion, ResultType,
+                               /*CanBeSubclass=*/true);
----------------
Would it be possible for this to reset the type to a less specific type? (What 
happens if the method was inlined and we already inferred the value of the 
returned symbolic region.)
Same question for where we update the type in  dynamicTypePropagationOnCasts.

This also introduces a situation where both tables track the type. Maybe we 
should add a TODO here?




http://reviews.llvm.org/D12916



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to