xazax.hun added a comment.

Hi!

Thank you for the patch!

What happens if you factor the "index + 1" expression out into a separate 
variable?
E.g.: unsigned temp = index + 1; and use temp in the condition?

My impression is that, the ranges does not model the overflow behavior 
correctly (which is well defined for unsigned values). I wondering why do you 
think that, the right way to solve this is to modify assumeSymNE and 
assumeSymEQ? Wouldn't it be better to actually handle the ranges properly on 
assignments and other operations (such as +), so assumeSymNE and assumeSymEQ 
can remain unmodified?


http://reviews.llvm.org/D12901



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to