aaron.ballman added a comment.

Generally LGTM, with one question about guarding against overflow.


================
Comment at: lib/Sema/SemaStmtAsm.cpp:447
@@ +446,3 @@
+    // Make sure no more than one input constraint matches each output.
+    if (InputMatchedToOutput[TiedTo] != ~0U) {
+      Diag(NS->getInputExpr(i)->getLocStart(),
----------------
Is it possible for InputConstraintsInfos.size() to be greater than 
OutputConstrainInfos.size()? Basically, I'm worried about buffer overflow here 
with TiedTo.


http://reviews.llvm.org/D12955



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to