On Fri, Sep 18, 2015 at 8:22 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> compnerd accepted this revision. > compnerd added a reviewer: compnerd. > compnerd added a comment. > This revision is now accepted and ready to land. > > Looks fine minus the one thing that needs a quick look at. > > > ================ > Comment at: include/clang/Driver/Options.td:952 > @@ -951,1 +951,3 @@ > def fno_pie : Flag<["-"], "fno-pie">, Group<f_Group>; > +def fplugin : Joined<["-"], "fplugin=">, Group<f_Group>, > Flags<[DriverOption]>, MetaVarName<"<dsopath>">, > + HelpText<"Load the named plugin (dynamic shared object)">; > ---------------- > Don't most options of this type use the _EQ suffix? Might be nice to > follow the convention. Please follow the rules listed on lines 106-123 of this file. > Repository: > rL LLVM > > http://reviews.llvm.org/D12903 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
