compnerd added inline comments.

================
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+  else if (Args.hasArg(options::OPT_fno_declspec))
+    CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
----------------
@rsmith, so they are.  I misread something and was thinking they were under 
CC1Options.td.

================
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+  else if (Args.hasArg(options::OPT_fno_declspec))
+    CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
----------------
compnerd wrote:
> @rsmith, so they are.  I misread something and was thinking they were under 
> CC1Options.td.
Sure, but you are still giving -fno-declspec precedence over -fdeclspec.  
Consider -fno-declspec -fdeclspec.  I think what you want is Args.getLastArg, 
not Args.hasArg.


http://reviews.llvm.org/D13322



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to