curdeius added inline comments. ================ Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ + if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\""; process.StartInfo.CreateNoWindow = true; ---------------- klimek wrote: > Don't we need " escaping for assumeFilename? (or do we consider that an > error? in which case, would we want to make that an error?) Well, quotes (") are not allowed as a part of a file name on Windows. What we could do is to strip surrounding quotes if the user added them in order not to add them twice.
http://reviews.llvm.org/D13549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits