labrinea added a comment.
Is this revision valid after all? I am confused by Tim's comment. I did not see
any regressions locally.
================
Comment at: lib/Driver/ToolChain.cpp:472
@@ -471,2 +471,3 @@
+ bool ThumbDefault = (ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
(Suffix.startswith("v7") && getTriple().isOSBinFormatMachO());
// FIXME: this is invalid for WindowsCE
----------------
rengolin wrote:
> You could cache the profile and use it here, too.
I don't see any checks based on profile in this line.
================
Comment at: test/Driver/arm-ias-Wa.s:75
@@ +74,3 @@
+
+// RUN: %clang -target thumbv7m-none-eabi -c %s -### 2>&1 \
+// RUN: | FileCheck -check-prefix=CHECK-M-PROFILE %s
----------------
rengolin wrote:
> You should also add "armv7m" and check that it defaults to Thumb, no?
It does default to thumb, if we are happy with this check I can add it.
http://reviews.llvm.org/D14121
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
