aaron.ballman added inline comments.

================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
 
+            IComponentModel componentModel = 
GetService(typeof(SComponentModel)) as IComponentModel;
+            editorAdaptersFactoryService = 
componentModel.GetService<IVsEditorAdaptersFactoryService>();
----------------
berenm wrote:
> I did more tests on my side, and apparently this line does not work on 
> VS2012, componentModel is null. I don't know at all why and how to fix it, 
> and it works fine starting with VS2013.
Our minimum supported MSVC version for development is 2013. Do we document 
supported versions for clang-format? Do we want to support versions older than 
the development version we're on?


http://reviews.llvm.org/D12407



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to