jroelofs added a subscriber: jroelofs. ================ Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114 @@ +113,3 @@ + printMethodNameWithPramaTypes(Out, C, FName, M, false); + const std::string NS = qtNormalizeSignature(Out.str()); + if (NS == MethodWithParamsNorm) ---------------- Why are you throwing away all the work that the parser did to build up the type signature as a QualType, pretty-printing it, and the re-parsing it by hand? ISTM it would be much better if qtNormalizeSignature had this type signature: `QualType qtNormalizeSignature(QualType)`.
http://reviews.llvm.org/D14592 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
