rjmccall added a comment. Thank you. A few more style complaints; with those fixed, LGTM.
================ Comment at: lib/CodeGen/TargetInfo.cpp:166 @@ +165,3 @@ +// Dynamically round a pointer up to a multiple of the given alignment. +static llvm::Value* emitRoundPointerUpToAlignment(CodeGenFunction &CGF, + llvm::Value *Ptr, ---------------- Minor code-style nitpick: please put the * next to the function name, not the type. ================ Comment at: lib/CodeGen/TargetInfo.cpp:216 @@ -208,1 +215,3 @@ + else + Addr = Address(Ptr, SlotSize); ---------------- LLVM code style is to always leave the braces there. ================ Comment at: lib/CodeGen/TargetInfo.cpp:3087 @@ -3089,1 +3086,3 @@ + overflow_arg_area = emitRoundPointerUpToAlignment(CGF, overflow_arg_area, + Align); ---------------- Braces. http://reviews.llvm.org/D14871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
