jroelofs requested changes to this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision now requires changes to proceed.
I'm getting a couple of test failures from this patch: Clang :: Driver/linux-header-search.cpp Clang :: Driver/solaris-header-search.cpp For the latter of the two, the driver picks: test/Driver/Inputs/sparc-sun-solaris2.11/usr/gcc/.8/include/c++/4.8.2/sparc-sun-solaris2.11 as the `-internal-isystem` directory, which doesn't exist. It should be finding: test/Driver/Inputs/sparc-sun-solaris2.11/usr/gcc/4.8.2/include/c++/4.8.2/sparc-sun-solaris2.11 I think it might be because `GoodVersion.MajorStr` is no longer set. http://reviews.llvm.org/D14727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
