sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Makes sense, thanks! ================ Comment at: clangd/tool/ClangdMain.cpp:161 +static llvm::cl::opt<bool> NoHeaderInsertDecorators( + "no-header-insert-decorators", + llvm::cl::desc( ---------------- Please invert the sense of this to avoid a double negative: "header-insert-decorators" with default true. Consider insert->insertion, because currently is not clear whether to read as (header (insert decorators)) or as ((header insert) decorators). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
