Can you point me to such a discussion about trailing whitespace? It seems to contradict the conclusion in another current thread to not consider churn for out-of-tree users (for C++ API in this case)
https://lists.llvm.org/pipermail/cfe-dev/2018-July/058579.html > We have historically taken the position that the churn caused for > out-of-tree users of the C++ API are not a consideration when performing an > API refactoring. (For two reasons: one is that we explicitly do not have a > stable C++ API; the other is that this is the mechanism by which we > encourage people to upstream changes.) This actually seems like a > relatively easy change in that regard: client code can be largely updated > by a regular expression. Michael 2018-07-30 15:36 GMT-05:00 Aaron Ballman <aa...@aaronballman.com>: > On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse > <llvm-comm...@meinersbur.de> wrote: >> I think removing trailing space is a good thing. Some editors remove >> any trailing space when saving a file. This shows up in diffs that I >> then have to undo manually. > > I've also run into the same issues on occasion. However, this isn't > about whether we dislike trailing spaces or not; it's about NFC churn > for out of tree users who have to try to keep their local patches > clean against upstream. This kind of churn makes for merge conflicts > and this is a the reason the community has traditionally rejected > these large-scale commits in the past. If we want to change that > policy, it should come after community discussion and agreement. > > ~Aaron _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits