Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

[Evgeniy Stepanov via cfe-commits]

eugenis added a comment.

added some docs


================
Comment at: lib/CodeGen/CodeGenModule.cpp:1041
@@ -988,3 +1040,3 @@
 void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) {
   assert(!GV->isDeclaration() &&
          "Only globals with definition can force usage.");
----------------
pcc wrote:
> What about callers of `EmitCfiSlowPathCheck`?
updated

================
Comment at: lib/CodeGen/CodeGenModule.cpp:1041
@@ -988,3 +1040,3 @@
 void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) {
   assert(!GV->isDeclaration() &&
          "Only globals with definition can force usage.");
----------------
eugenis wrote:
> pcc wrote:
> > What about callers of `EmitCfiSlowPathCheck`?
> updated
fixed


Repository:
  rL LLVM

http://reviews.llvm.org/D15367



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits