leonardchan added a comment.


> You shouldn't be adding your own `ExpressionEvaluationContextRecord`s. What I 
> was suggesting is that you store a list of pending `noderef` expressions on 
> the record, and diagnose them when the record is popped (if they've not been 
> removed since).

This is what I initially tried but the last record left on the stack, which is 
what I add them to, wasn't getting popped. While parsing, the stack of records 
(from what I've observed) has only one record that doesn't get popped via 
`PopExpressionEvaluationContext`. I'm still looking into ways to try to do this 
though.

> That said... have you considered changing the specification of your attribute 
> so that you warn on lvalue-to-rvalue conversions instead of warning on 
> dereference-like things with a list of exceptions?

I'll look into this for the next revision on this patch.


Repository:
  rC Clang

https://reviews.llvm.org/D49511



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to