On 2018-08-01 01:30 PM, Alex L wrote: > Is there a particular reason why this commit didn't have a corresponding test > included? > Cheers, > Alex
Back when we made the corresponding change in "onChangeConfiguration", there was no straightforward way to make a lit test for it: https://reviews.llvm.org/D39571?id=124024#inline-359345 I am not sure, but I think the issue was that we had to hard-code the length of the messages we sent. Since we had to use temp directory names, the length was not known in advance. I don't think we have that limitation anymore. We would need to create a temporary directory hierarchy, and then refer to it in the messages we send to switch between build configurations. Is it something that sounds possible with lit? Do you know about other tests doing something similar? Thanks, Simon _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
