aaron.ballman accepted this revision.
aaron.ballman added a reviewer: alexfh.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from two tiny nits, LGTM. Thank you for working on this, it's a great
feature! I think we should add something to the release notes to make sure it
gets called out.
================
Comment at: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp:156
@@ -149,1 +155,3 @@
+ unsigned WErrorCount() { return WErrors; }
+
----------------
Method can be const.
================
Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7
@@ +6,3 @@
+// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment
[llvm-namespace-comment]
+// CHECK-WERR: error: namespace 'j' not terminated with a closing comment
[llvm-namespace-comment, -Werrors=]
+
----------------
One of these tests should complete the -Werrors= chunk just to be sure it's
getting printed properly.
http://reviews.llvm.org/D15528
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
