aaronpuchert added inline comments.
================
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+ mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
----------------
aaron.ballman wrote:
> Nothing calls either of these functions within the test; is that intended?
Yes, I just wanted to check that there are no warnings within the functions.
Before the changes in `lib/Analysis/ThreadSafety.cpp`, we would get a warning
"releasing mutex 'mu' using shared access, expected exclusive access" on line
4086.
My changes address the attributes on the function being analyzed, not on a
function that is called from the function being analyzed.
Repository:
rC Clang
https://reviews.llvm.org/D50110
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
