On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < revi...@reviews.llvm.org> wrote:
> arphaman added a comment. > > In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > > > What's the motivation for clangd to differ from clang here? (& if the > first > > letter is going to be capitalized, should there be a period at the end? > But > > also the phrasing of most/all diagnostic text isn't in the form of > complete > > sentences, so this might not make sense) > > > It's mostly for the presentation purposes, to match the needs of our > client. I first implemented it as an opt-in feature, but the consensus was > to capitalize the messages all the time. > Doesn't seem like it'd be any more expensive (amount of code or performance) to do that up in your client code, then, would it? I guess if most users of this API in time ended up preferring capitalized values, it'd make sense to share that implementation - but to me it seems like a strange transformation to happen at this level. (since it depends on what kind of client/how they want to render things - so it seems an odd choice to bake in to the API (or even provide an option for, unless there are lots of users/the code was especially complicated)) My 2c - I've no vested interest or authority here. > I don't think it would make sense to insert the period at the end, > because, as you said, not all diagnostics are complete sentences > > > Repository: > rCTE Clang Tools Extra > > https://reviews.llvm.org/D50154 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
