mstorsjo added inline comments.
================ Comment at: include/unwind.h:46 +typedef uintptr_t _Unwind_Ptr; +#endif + ---------------- What other reference is this list of typedefs for `_Unwind_Ptr` based on? I don't see any of these cases in clang's unwind.h at least. ================ Comment at: include/unwind.h:172 struct _Unwind_Context* context); +typedef _Unwind_Personality_Fn __personality_routine; #endif ---------------- Minor nitpick: Would it make sense to move the `typedef _Unwind_Personality_Fn __personality_routine;` out of the ifdef, since the same one can be used for both cases? Repository: rUNW libunwind https://reviews.llvm.org/D50413 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits