rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM with a small bugfix. ================ Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1122 + for (Decl *D : MemberGet) { + if (FunctionTemplateDecl *FTD = dyn_cast<FunctionTemplateDecl>(D)) { + TemplateParameterList *TPL = FTD->getTemplateParameters(); ---------------- You should use `D->getUnderlyingDecl()` rather than just `D` here, otherwise you'll reject this: ``` struct A { template<int> void get(); }; struct B : A { using A::get; }; ``` ... because `D` will be a `UsingShadowDecl` not a `FunctionTemplateDecl`. (Please also add a corresponding testcase.) https://reviews.llvm.org/D50418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits