ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM with a small NIT. ================ Comment at: clangd/ClangdLSPServer.cpp:507 + } + LSPDiag["clangd.fixes"] = std::move(ClangdFixes); + } ---------------- NIT: maybe avoid `.` and use something like `clangd_fixes`? having dots in the object keys might be awkward if someone tries to use those from javascript. (not that we have these use-cases now, but still) https://reviews.llvm.org/D50415 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
