ldionne added a comment. In https://reviews.llvm.org/D50652#1198893, @ldionne wrote:
> In https://reviews.llvm.org/D50652#1198885, @hans wrote: > > > Oh, or could we do > > > > -D_LIBCPP_HIDE_FROM_ABI= > > > > > > and just get regular odr linkage for these functions? > > > No, you do need to use `_LIBCPP_HIDDEN _LIBCPP_ALWAYS_INLINE` because of the > issue described in > http://lists.llvm.org/pipermail/llvm-dev/2018-July/124549.html. But yeah, > Chromium could use this workaround. Actually, scratch that, it does work. One can either use `-D_LIBCPP_HIDE_FROM_ABI=_LIBCPP_HIDDEN _LIBCPP_ALWAYS_INLINE` to restore the old behavior, or `-D_LIBCPP_HIDE_FROM_ABI=` to get odr linkage. Repository: rCXX libc++ https://reviews.llvm.org/D50652 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits