ldionne added a comment. The goal of this commit is to fix build bot failures here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions/builds/286/steps/test.libcxx/logs/stdio. This failure was introduced when I fixed some unit tests that were no-ops in https://reviews.llvm.org/D50674 -- I didn't test that change on Linux so I didn't catch the failure before the bots notified me.
To test this change, I bootstrapped a Docker image with a configuration similar to the build bot, and was able to reproduce the issue. Applying this patch fixed the issue. Side note: we should probably strive to have docker containers for as many libc++ build bots as possible -- this makes it possible to reproduce failures locally, which is otherwise a guessing game. Even better -- we could run better tests before submitting a change and avoid breaking the build altogether! Repository: rCXX libc++ https://reviews.llvm.org/D50719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
