steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land.
This looks like a NFC change. Given that the next patch moves these methods out of line, you might consider introducing them out of line here (and moving the constructors out of line). That would make the next patch easier to review because the addition of assertion handling would be move visible. LGTM, but I'm new here, so you may want to wait for another reviewer if you wish. Repository: rC Clang https://reviews.llvm.org/D50764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
