lebedev.ri added reviewers: aaron.ballman, zinovy.nis. lebedev.ri added a comment.
In https://reviews.llvm.org/D50852#1203009, @hugoeg wrote: > In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote: > > > 1. Please always upload all patches with full context. > > 2. There already is `modernize-use-auto`. Does it handle this case? Then > > this should be just an alias to that check. Else, i think it would be best > > to extend that one, and still alias. > > > since this check checks for absl::make_unique primarily > if we move it to the general check, it'd be weird to check for > absl::make_unique Why do you think it would be weird? That list should/would be a user-configurable config option anyway. > right now our main goal is to release checks tailored specifically to abseil > users, so if we can we would like to release this check separately in the > abseil directory Just checking, was there some memo i missed that abseil-related checks are exempt from all the usual guidelines? Because this check is really not abseil-library-specific. https://reviews.llvm.org/D50852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
