Eugene.Zelenko added inline comments.
================ Comment at: docs/clang-tidy/checks/abseil-faster-strsplit-delimiter.rst:6 + +This check triggers on calls to ``absl::StrSplit()`` or ``absl::MaxSplits()`` +where the delimiter is a single character string literal. The check will offer ---------------- Please make first statement same as in Release Notes. Please also avoid //this check//. ================ Comment at: docs/clang-tidy/checks/abseil-faster-strsplit-delimiter.rst:21 + for (auto piece : absl::StrSplit(str, "B")) { + // Suggested - the argument is a character, which causes the more efficient + // overload of absl::StrSplit() to be used. ---------------- Please separate before and after with empty line. Same in other places. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits