hokein added a comment. In https://reviews.llvm.org/D50896#1204310, @ilya-biryukov wrote:
> This change LG, but I would not commit it before we have an actual > implementation. > As soon as we have the `references` function in `ClangdUnit.cpp` > implemented, the merge of this change should be trivial. > > Is there any value in committing empty stubs before an actual implementation > is ready? Actually, I'd prefer to get it submitted before we have the actual implementation -- because it would make use easier to experience xrefs features in LSP clients when adding xrefs actual implemenation (without patching the whole patch locally). Is there any concern about it? Since we disable it by default, it would not affect any users. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50896 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
