mgrang added a comment.

In https://reviews.llvm.org/D50488#1203876, @Szelethus wrote:

> I think testcases for non-class iterator objects would be valuable.


Thanks @Szelethus. Yes, as you correctly pointed out this would not match 
non-class iterator objects.

This is my first time with ASTMatchers and I am not sure how to get the 
value_type from hasType (I don't see a matcher for value_types in 
ASTMatchers.h). Would I end up using a visitor for that? If yes, then maybe the 
entire check for pointer types needs to be done via visitors? Sorry for the 
newbie questions :)


https://reviews.llvm.org/D50488



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to