george.karpenkov added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:537 + mutable APIMisuse BT{this, "null passed to CF memory management function"}; + CallDescription CFRetain{"CFRetain", 1}, + CFRelease{"CFRelease", 1}, ---------------- I personally would prefer being less fancy, and avoiding the comma operator, but I suppose it's a matter of style. ================ Comment at: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:567 + ProgramStateRef stateNonNull, stateNull; + std::tie(stateNonNull, stateNull) = state->assume(*DefArgVal); ---------------- There's also DefArgVal Repository: rC Clang https://reviews.llvm.org/D50866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits